Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add access token strategy parameter to cli #3718

Merged

Conversation

jagobagascon
Copy link
Contributor

This PR allows setting the access token strategy using the Hydra CLI: --access-token-strategy jwt.

Related issue(s)

#3717

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@jagobagascon jagobagascon force-pushed the feature/cli-add-access-token-strategy-param branch from 790e4dc to 60a2588 Compare February 14, 2024 15:51
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.23%. Comparing base (57096be) to head (0e085e1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3718   +/-   ##
=======================================
  Coverage   76.22%   76.23%           
=======================================
  Files         134      134           
  Lines       10210    10212    +2     
=======================================
+ Hits         7783     7785    +2     
  Misses       1910     1910           
  Partials      517      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this to update client as well?

@jagobagascon
Copy link
Contributor Author

Aren't create and update methods sharing their flags via cmd_helper_client.go ?

@jagobagascon jagobagascon force-pushed the feature/cli-add-access-token-strategy-param branch from 440b725 to 0e085e1 Compare March 5, 2024 10:38
@aeneasr
Copy link
Member

aeneasr commented Mar 5, 2024

You're right!

@aeneasr aeneasr merged commit 7862dc3 into ory:master Mar 5, 2024
30 checks passed
@jagobagascon jagobagascon deleted the feature/cli-add-access-token-strategy-param branch March 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants