-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update persister_oauth2.go to handle special character | coming in t… #3849
base: master
Are you sure you want to change the base?
Conversation
…e scopes as part of consent request Url encoded and decoded while fetching values from the table, as "|" is a seperator used to store scopes
Links to #3829 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a backwards incompatible change that will break all existing rows. I don't think there's appetite to fix this at the moment and the solution would need to be backwards compatible and well-tested. It's probably easier to just adjust the scope charset
@aeneasr can you please elaborate, i did try to encode , but since this logic is more controlled in the Hydra, it just took that param as "%7C" and responded with scopes having "%7C" instead of "|" We cant replace the | (pipe) char ,as its a requirement from Hl7 Smart App launch https://www.hl7.org/fhir/smart-app-launch/scopes-and-launch-context.html#finer-grained-resource-constraints-using-search-parameters Were you suggesting some other way to fix this issue? |
…he scopes as part of consent request
Url encoded and decoded while fetching values from the table, as "|" is a seperator used to store scopes
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments