-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow partially failing batch inserts #4083
feat: allow partially failing batch inserts #4083
Conversation
05027a7
to
447c5d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4083 +/- ##
==========================================
- Coverage 79.00% 78.64% -0.36%
==========================================
Files 377 377
Lines 27492 26963 -529
==========================================
- Hits 21720 21205 -515
+ Misses 4165 4149 -16
- Partials 1607 1609 +2 ☔ View full report in Codecov by Sentry. |
6fae6d9
to
0ed2ed1
Compare
…-patch-identities-error-messages
…-patch-identities-error-messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now, just some small nits.
…-patch-identities-error-messages
When batch-inserting multiple identities, conflicts or validation errors of a subset of identities in the batch still allow the rest of the identities to be inserted. The returned JSON contains the error details that lead to the failure.
Related issue(s)
Docs PR: ory/docs#1864
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments