Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jackson provider #4242

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat: jackson provider #4242

wants to merge 12 commits into from

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Dec 10, 2024

This adds a jackson provider to Kratos.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (8cbb5bd) to head (42e8aef).

Files with missing lines Patch % Lines
selfservice/strategy/oidc/strategy_registration.go 20.00% 3 Missing and 1 partial ⚠️
selfservice/flow/registration/handler.go 0.00% 3 Missing ⚠️
selfservice/strategy/oidc/strategy.go 88.23% 2 Missing ⚠️
selfservice/flow/login/handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4242      +/-   ##
==========================================
- Coverage   79.10%   78.57%   -0.53%     
==========================================
  Files         381      381              
  Lines       28012    27316     -696     
==========================================
- Hits        22159    21464     -695     
- Misses       4209     4229      +20     
+ Partials     1644     1623      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr changed the title feat: saml provider feat: jackson provider Dec 11, 2024
selfservice/strategy/oidc/strategy_login.go Outdated Show resolved Hide resolved
@@ -164,6 +164,13 @@ func (s *Strategy) Register(w http.ResponseWriter, r *http.Request, f *registrat
span.SetAttributes(attribute.String("not_responsible_reason", "provider ID missing"))
return errors.WithStack(flow.ErrStrategyNotResponsible)
}
// This is a hack for a lack of a `method` field in the form body.
if prefix, _, ok := strings.Cut(pid, ":"); ok {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced by

func WithUnknownProviderHandler(handler func(error) error) NewStrategyOpt {
return func(s *Strategy) { s.handleUnknownProviderError = handler }
}

embedx/config.schema.json Outdated Show resolved Hide resolved
@hperl hperl requested a review from aeneasr December 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants