-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jackson provider #4242
base: master
Are you sure you want to change the base?
feat: jackson provider #4242
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4242 +/- ##
==========================================
- Coverage 79.10% 78.57% -0.53%
==========================================
Files 381 381
Lines 28012 27316 -696
==========================================
- Hits 22159 21464 -695
- Misses 4209 4229 +20
+ Partials 1644 1623 -21 ☔ View full report in Codecov by Sentry. |
@@ -164,6 +164,13 @@ func (s *Strategy) Register(w http.ResponseWriter, r *http.Request, f *registrat | |||
span.SetAttributes(attribute.String("not_responsible_reason", "provider ID missing")) | |||
return errors.WithStack(flow.ErrStrategyNotResponsible) | |||
} | |||
// This is a hack for a lack of a `method` field in the form body. | |||
if prefix, _, ok := strings.Cut(pid, ":"); ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced by
kratos/selfservice/strategy/oidc/strategy.go
Lines 212 to 214 in 42e8aef
func WithUnknownProviderHandler(handler func(error) error) NewStrategyOpt { | |
return func(s *Strategy) { s.handleUnknownProviderError = handler } | |
} |
This adds a jackson provider to Kratos.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments