Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version comparison #1229

Closed
wants to merge 2 commits into from
Closed

Conversation

KochynVolodymyr
Copy link
Contributor

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Fixed logical mistake in operator< for Version class.
All cases covered by unit tests.

Which part of the code base require a change

  • Library: foedagcore
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (8d01d61) 6.78% compared to head (caba467) 6.82%.
Report is 1 commits behind head on main.

❗ Current head caba467 differs from pull request most recent head 8a1bfd5. Consider uploading reports for the commit 8a1bfd5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1229      +/-   ##
========================================
+ Coverage   6.78%   6.82%   +0.04%     
========================================
  Files        246     246              
  Lines      24920   24924       +4     
  Branches   14332   14333       +1     
========================================
+ Hits        1691    1702      +11     
+ Misses     22969   22962       -7     
  Partials     260     260              
Files Changed Coverage Δ
src/Main/ProjectFile/ProjectFileComponent.cpp 32.35% <100.00%> (+32.35%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KochynVolodymyr
Copy link
Contributor Author

More unit tests will be provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant