Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version comparison used for project migration #1230

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

KochynVolodymyr
Copy link
Contributor

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

Fixed logical mistake in operator< for Version class.
All cases covered by unit tests.

Which part of the code base require a change

  • Library: foedagcore
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (8d01d61) 6.78% compared to head (2399f3b) 6.91%.
Report is 1 commits behind head on main.

❗ Current head 2399f3b differs from pull request most recent head 45c2ddd. Consider uploading reports for the commit 45c2ddd to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1230      +/-   ##
========================================
+ Coverage   6.78%   6.91%   +0.12%     
========================================
  Files        246     246              
  Lines      24920   24925       +5     
  Branches   14332   14333       +1     
========================================
+ Hits        1691    1723      +32     
+ Misses     22969   22942      -27     
  Partials     260     260              
Files Changed Coverage Δ
src/Main/ProjectFile/ProjectFileComponent.h 63.63% <ø> (+9.09%) ⬆️
src/Main/ProjectFile/ProjectFileComponent.cpp 88.57% <100.00%> (+88.57%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravic-rs ravic-rs merged commit f551d09 into main Aug 21, 2023
26 checks passed
@ravic-rs ravic-rs deleted the fixed-version-comparison branch August 21, 2023 16:32
@ravic-rs ravic-rs changed the title Fixed version comparison Fixed version comparison used for project migration Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants