Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDA-1938] Enable write logs to file when --mute option set #1239

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

KochynVolodymyr
Copy link
Contributor

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

When --mute option is used, logs will write to the log file. Standard output still remains muted.

Which part of the code base require a change

  • Library: foedagcore
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 47.61% and project coverage change: -0.01% ⚠️

Comparison is base (bd98a7a) 7.69% compared to head (794f2d6) 7.69%.

❗ Current head 794f2d6 differs from pull request most recent head 378908b. Consider uploading reports for the commit 378908b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1239      +/-   ##
========================================
- Coverage   7.69%   7.69%   -0.01%     
========================================
  Files        248     248              
  Lines      25448   25444       -4     
  Branches   14660   14658       -2     
========================================
- Hits        1959    1957       -2     
+ Misses     23082   23081       -1     
+ Partials     407     406       -1     
Files Changed Coverage Δ
src/Command/CommandStack.h 0.00% <ø> (ø)
src/Main/Foedag.cpp 0.00% <0.00%> (ø)
src/Command/CommandStack.cpp 62.50% <76.92%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravic-rs ravic-rs merged commit 73c6c32 into main Aug 23, 2023
1 check passed
@ravic-rs ravic-rs deleted the task/EDA-1938/dump-to-file-when-mute-enable branch August 23, 2023 17:19
@ravic-rs
Copy link
Contributor

ravic-rs commented Aug 31, 2023

RG-470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants