Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for OCLA Parser #1246

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Preparation for OCLA Parser #1246

merged 7 commits into from
Aug 28, 2023

Conversation

chungshien
Copy link
Contributor

@chungshien chungshien commented Aug 28, 2023

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Cosmetic changes
Prepare few paths that needed by OCLA Parser

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 64.28% and project coverage change: +0.02% 🎉

Comparison is base (653f3a3) 8.43% compared to head (755331b) 8.45%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1246      +/-   ##
========================================
+ Coverage   8.43%   8.45%   +0.02%     
========================================
  Files        251     251              
  Lines      25859   25865       +6     
  Branches   14863   14867       +4     
========================================
+ Hits        2180    2186       +6     
- Misses     23209   23211       +2     
+ Partials     470     468       -2     
Files Changed Coverage Δ
src/Compiler/Compiler.cpp 0.29% <0.00%> (-0.01%) ⬇️
src/Compiler/Compiler.h 3.57% <ø> (ø)
src/Configuration/CFGCompiler/CFGCompiler.cpp 21.27% <25.00%> (-0.71%) ⬇️
src/Configuration/CFGCommon/CFGCommon.cpp 58.64% <100.00%> (+1.84%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravic-rs
Copy link
Contributor

Please "Squash and Merge" PRs when approved.
image

@alain-rs alain-rs merged commit 9fc6ad9 into main Aug 28, 2023
@alain-rs alain-rs deleted the foedag-ocla branch August 28, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants