Sdt dev zaid #1249
Merged
Sdt dev zaid #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zaidtahirbutt
commented
Aug 28, 2023
zaidtahirbutt
commented
… have been added to the DesignQuery folder
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
========================================
- Coverage 8.90% 8.15% -0.76%
========================================
Files 251 253 +2
Lines 25942 28349 +2407
Branches 14891 16286 +1395
========================================
Hits 2311 2311
- Misses 23130 25537 +2407
Partials 501 501
☔ View full report in Codecov by Sentry. |
ravic-rs
reviewed
Aug 29, 2023
src/DesignQuery/scripts/cpp_script_for_sdt_generation/main_sdtgen_cpp_nlohman_lib_v5.cpp
Outdated
Show resolved
Hide resolved
ravic-rs
reviewed
Aug 29, 2023
src/DesignQuery/scripts/cpp_script_for_sdt_generation/output_sdtgen_cpp_nlohman_lib_v5.sdt
Outdated
Show resolved
Hide resolved
ravic-rs
reviewed
Aug 29, 2023
...esignQuery/scripts/tcl_script_for_sdt_generation/JSON_Files/GPIO_Yosis_Ver_Example/README.md
Outdated
Show resolved
Hide resolved
ravic-rs
reviewed
Aug 29, 2023
ravic-rs
reviewed
Aug 29, 2023
...s/tcl_script_for_sdt_generation/example_SDT_files/gemini_experimentalz_commented_version.sdt
Outdated
Show resolved
Hide resolved
ravic-rs
reviewed
Aug 29, 2023
ravic-rs
reviewed
Aug 29, 2023
ravic-rs
reviewed
Aug 29, 2023
ravic-rs
reviewed
Aug 29, 2023
...s/tcl_script_for_sdt_generation/example_SDT_files/gemini_experimentalz_commented_version.sdt
Outdated
Show resolved
Hide resolved
…uest of this branch into main
…uest of this branch into main
…uest of this branch into main
…uest of this branch into main
ravic-rs
reviewed
Aug 30, 2023
ravic-rs
reviewed
Aug 30, 2023
ravic-rs
reviewed
Aug 30, 2023
ravic-rs
reviewed
Aug 30, 2023
ravic-rs
reviewed
Aug 30, 2023
ravic-rs
reviewed
Aug 31, 2023
| @@ -58,7 +72,8 @@ std::filesystem::path DesignQuery::GetProjDir() const { | |||
|
|
|||
| std::filesystem::path DesignQuery::GetHierInfoPath() const { | |||
| std::filesystem::path dir = GetProjDir(); | |||
| std::filesystem::path hier_info = "hier_info.json"; | |||
| std::filesystem::path hier_info = | |||
| "./tests/Testcases/DesignQuery/hier_info.json"; | |||
There was a problem hiding this comment.
We will have to fix this path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.