Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if PinTable exist before calling gen_bitstream_setting_xml #1716

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

chungshien-chai
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Check if pin table exist before calling gen_bitstream_setting_xml

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 14.75%. Comparing base (494be28) to head (2ae92be).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Compiler/CompilerOpenFPGA.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
- Coverage   14.75%   14.75%   -0.01%     
==========================================
  Files         478      478              
  Lines       66518    66519       +1     
  Branches    26164    26183      +19     
==========================================
  Hits         9812     9812              
- Misses      55470    55472       +2     
+ Partials     1236     1235       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai chungshien-chai merged commit 73e268c into main Nov 7, 2024
32 of 35 checks passed
@chungshien-chai chungshien-chai deleted the FOEDAG-bitstream branch November 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant