Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For EDA 3310 #1718

Merged
merged 2 commits into from
Nov 22, 2024
Merged

For EDA 3310 #1718

merged 2 commits into from
Nov 22, 2024

Conversation

manadher
Copy link
Contributor

Motivate of the pull request

  • [ x ] To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 14.74%. Comparing base (c10906b) to head (95df625).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Compiler/Compiler.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
- Coverage   14.75%   14.74%   -0.01%     
==========================================
  Files         478      478              
  Lines       66520    66530      +10     
  Branches    26196    26117      -79     
==========================================
  Hits         9812     9812              
+ Misses      55465    55462       -3     
- Partials     1243     1256      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@manadher
Copy link
Contributor Author

@ravikiranchollangi The error on windows has nothing to do with my changes :

2024-11-22T00:53:09.8158601Z C:\msys64\mingw64\bin\c++.exe -DCOMPILER_LIBRARY -DMINGW_HAS_SECURE_API=1 -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XML_LIB -DUNICODE -DUSE_IPA -DWIN32 -DWIN64 -DWINVER=0x0A00 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WIN64 -ID:/a/FOEDAG/FOEDAG/build/src/Compiler -ID:/a/FOEDAG/FOEDAG/src/Compiler -ID:/a/FOEDAG/FOEDAG/build/src/Compiler/compiler_autogen/include -ID:/a/FOEDAG/FOEDAG/third_party/spdlog/include -ID:/a/FOEDAG/FOEDAG/third_party/exprtk -ID:/a/FOEDAG/FOEDAG/third_party/scope_guard -ID:/a/FOEDAG/FOEDAG/src/Compiler/../../src -ID:/a/FOEDAG/FOEDAG/src/Compiler/.. -ID:/a/FOEDAG/FOEDAG/build/src/Compiler/../../include -isystem C:/msys64/mingw64/include/qt6/QtWidgets -isystem C:/msys64/mingw64/include/qt6 -isystem C:/msys64/mingw64/include/qt6/QtCore -isystem C:/msys64/mingw64/share/qt6/mkspecs/win32-g++ -isystem C:/msys64/mingw64/include/qt6/QtGui -isystem C:/msys64/mingw64/include/qt6/QtXml -O3 -DNDEBUG -Werror -Wall -std=gnu++17 -MD -MT src/Compiler/CMakeFiles/compiler.dir/TaskTableView.cpp.obj -MF src\Compiler\CMakeFiles\compiler.dir\TaskTableView.cpp.obj.d -o src/Compiler/CMakeFiles/compiler.dir/TaskTableView.cpp.obj -c D:/a/FOEDAG/FOEDAG/src/Compiler/TaskTableView.cpp
2024-11-22T00:53:09.8170172Z D:/a/FOEDAG/FOEDAG/src/Compiler/TaskTableView.cpp: In member function 'virtual void FOEDAG::TaskTableView::setModel(QAbstractItemModel*)':
2024-11-22T00:53:09.8173210Z D:/a/FOEDAG/FOEDAG/src/Compiler/TaskTableView.cpp:111:32: error: 'void QCheckBox::stateChanged(int)' is deprecated: Use checkStateChanged() instead [-Werror=deprecated-declarations]
2024-11-22T00:53:09.8175226Z 111 | connect(check, &QCheckBox::stateChanged, this,
2024-11-22T00:53:09.8176064Z | ^~~~~~~~~~~~
2024-11-22T00:53:09.8177052Z In file included from C:/msys64/mingw64/include/qt6/QtWidgets/QCheckBox:1,
2024-11-22T00:53:09.8178213Z from D:/a/FOEDAG/FOEDAG/src/Compiler/TaskTableView.cpp:25:
2024-11-22T00:53:09.8179425Z C:/msys64/mingw64/include/qt6/QtWidgets/qcheckbox.h:41:10: note: declared here
2024-11-22T00:53:09.8180476Z 41 | void stateChanged(int);
2024-11-22T00:53:09.8181130Z | ^~~~~~~~~~~~
2024-11-22T00:53:14.5093940Z cc1plus.exe: all warnings being treated as errors

@ravikiranchollangi ravikiranchollangi merged commit 9683da9 into main Nov 22, 2024
32 of 35 checks passed
@ravikiranchollangi ravikiranchollangi deleted the EDA_3310 branch November 22, 2024 20:19
ravikiranchollangi added a commit that referenced this pull request Dec 1, 2024
ravikiranchollangi added a commit that referenced this pull request Dec 1, 2024
* Revert "For EDA 3310 (#1718)"

This reverts commit 9683da9.

* Incremented patch version

---------

Co-authored-by: ravikiranchollangi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants