Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring device.xml file from OSFPGA Raptor on fly in CI to run E2E tests #261

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

NadeemYaseen
Copy link
Contributor

@NadeemYaseen NadeemYaseen commented Nov 9, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

With device.xml gone from RPE repo, we will now download this file and related ones from Raptor on the fly from Raptor in CI to run tests

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Frontend:
  • Backend:
  • Library: <Specify the library name, e.g. npm packages>
  • Plug-in: <Specify the plugin name, e.g. Webpack, jtest>
  • Documentation
  • Regression tests
  • Continuous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break backward-compatibility. If so, please list who may be influenced.

@NadeemYaseen
Copy link
Contributor Author

@shivaahir158, for now, CI-related changes are done. I believe we can merge them. For tests related changes, you should start from main branch once these are merged,

FYI: @ravikiranchollangi

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (a75e247) to head (ffd2605).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         110      110           
  Lines        9022     9022           
  Branches      402      402           
=======================================
  Hits         6210     6210           
  Misses       2812     2812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shivaahir158 shivaahir158 merged commit d5a3058 into main Nov 9, 2024
11 checks passed
@shivaahir158 shivaahir158 deleted the playwrrite_test_patch branch November 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants