Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed psalm, test, coding standards and updated api spec #219

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Fixed psalm, test, coding standards and updated api spec #219

merged 11 commits into from
Nov 12, 2024

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Oct 24, 2024 •
edited
Loading

Description

Fixed psalm, test, coding standards and updated api spec.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj added the bug Something isn't working label Oct 24, 2024
@tuj tuj self-assigned this Oct 24, 2024
@tuj tuj changed the title Fixed bug where changing region in one playlist affects all other screens with the same region id Fix coding standards and psalm issues Oct 25, 2024
@tuj tuj changed the title Fix coding standards and psalm issues Fixed psalm, test, coding standards and updated api spec Nov 1, 2024
@tuj tuj requested a review from sinejespersen November 1, 2024 20:20
@tuj tuj merged commit 59ef26c into develop Nov 12, 2024
13 checks passed
@tuj tuj deleted the feature/bug-screen-playlist-region branch November 12, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turegjorup turegjorup turegjorup approved these changes

@sinejespersen sinejespersen Awaiting requested review from sinejespersen

Assignees

@tuj tuj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuj @turegjorup @sinejespersen