Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bug screen playlist region no coding standards #220

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Feature/bug screen playlist region no coding standards #220

merged 7 commits into from
Oct 25, 2024

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Oct 24, 2024

No description provided.

@tuj tuj added the bug Something isn't working label Oct 24, 2024
@tuj tuj self-assigned this Oct 24, 2024
turegjorup
turegjorup approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@turegjorup turegjorup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with commit:

  • Validate input object to ensure we have needed array keys
  • Clarified parameter naming
  • Ensure proper null checks
  • Include id in error messages if content not found to ease debugging for clients

@turegjorup turegjorup merged commit 50d064c into develop Oct 25, 2024
7 of 13 checks passed
@turegjorup turegjorup deleted the feature/bug-screen-playlist-region-no-coding-standards branch October 25, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turegjorup turegjorup turegjorup approved these changes

@sinejespersen sinejespersen Awaiting requested review from sinejespersen

Assignees

@tuj tuj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuj @turegjorup