Colibo feed type #226
Open
Colibo feed type #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/feed/feed-overview.md
Outdated
| booking system you can implement a "FeedSource" that fetches booking data from your source and normalizes it to match | ||
| the calendar output model. | ||
|
|
||
| @todo |
| { | ||
| $feedEntryRecipients = $this->feedService->getFeedSourceConfigUrl($feedSource, 'allowed-recipients'); | ||
|
|
||
| return [ |
There was a problem hiding this comment.
getAdminFormOptions returns the admin options for the given feed type in the form of an array of array elements.
sinejespersen
approved these changes
Dec 20, 2024
…/display-api-service into feature/2533_colibo_feed_type
tuj
reviewed
Dec 20, 2024
src/Service/FeedService.php
Outdated
| @@ -100,7 +100,7 @@ public function getData(Feed $feed): ?array | |||
| /** @var CacheItemInterface $cacheItem */ | |||
| $cacheItem = $this->feedsCache->getItem($feedId); | |||
|
|
|||
| if ($cacheItem->isHit()) { | |||
| if (false && $cacheItem->isHit()) { | |||
| { | ||
| $feedEntryRecipients = $this->feedService->getFeedSourceConfigUrl($feedSource, 'allowed-recipients'); | ||
|
|
||
| return [ |
There was a problem hiding this comment.
getAdminFormOptions returns the admin options for the given feed type in the form of an array of array elements.
sinejespersen
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/2533
Description
Checklist
Related PRs