HMS-3162: test: boot generated image and ensure ssh is working #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochosi
changed the title
|
Looks good, happy to approved when #24 is merged and this is rebased. :) |
mvo5
force-pushed
the
tmt-smoke-boot-vm
branch
from
0d8c943 to
cceb14e
Compare
mvo5
commented
Dec 7, 2023
mvo5
force-pushed
the
tmt-smoke-boot-vm
branch
3 times, most recently
from
e8489e1 to
d306cf5
Compare
mvo5
force-pushed
the
tmt-smoke-boot-vm
branch
2 times, most recently
from
5868880 to
6557abb
Compare
mvo5
force-pushed
the
tmt-smoke-boot-vm
branch
from
6557abb to
3a330cf
Compare
|
@mvo5 looks the action is not yet working well with RH ranch :( It fails to report the correct URL seems. http://artifacts.osci.redhat.com/testing-farm/54e53734-4050-45df-abff-c79e365d354c/ So seems tests run, but they failed on: |
|
@mvo5 never mind, you need to adjust https://github.com/sclorg/testing-farm-as-github-action/blob/main/action.yml#L78 |
|
My apologies for not realizing earlier, we do not use much this action 🤦 |
mvo5
force-pushed
the
tmt-smoke-boot-vm
branch
2 times, most recently
from
5d9594f to
bd2d8c2
Compare
Thank you for all your help with this! It looks like it's working fine, I'm very excited. |
|
Needs a rebase and conflict resolution. |
Do some more testing of the generated image by booting it and checking that ssh comes up. There will be a followup that will actually login into the VM and ensure that also works.
mvo5
force-pushed
the
tmt-smoke-boot-vm
branch
from
bd2d8c2 to
f158d30
Compare
ondrejbudai
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the extra check that the generated image from
podman run osbuild-deploy-containercan actually boot in qemu and will open the ssh port.