test: refactor monolithic test_smoke into multiple tests
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
reviewed
Dec 11, 2023
bcl
previously approved these changes
Dec 11, 2023
mvo5
force-pushed
the
refactor-tests
branch
3 times, most recently
from
99530ea
to
2c29c3a
Compare
The existing test_smoke was becoming a bit too big and especially the fact that part have to be skipped depending on the environment is really not nice. This commit refactors it to be more module. For this it uses the pytest session scope to ensure that the build container and the test image are only build once and then shared accross the various individual tests.
|
This includes now #50 which apparently was required to make the RHTAP build work (it was failing before without this). |
supakeen
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing test_smoke was becoming a bit too big and especially the fact that part have to be skipped depending on the environment is really not nice.
This commit refactors it to be more module. For this it uses the pytest session scope to ensure that the build container and the test image are only build once and then shared accross the various individual tests.