Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprints: Add flag to track on prem import usage #2614

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

avitova
Copy link
Contributor

@avitova avitova commented Nov 22, 2024

The flag can be used later to track the usage of on prem import feature.

@avitova avitova changed the title Track on prem Blueprints: Add flag to track on prem import usage Nov 22, 2024
Copy link
Collaborator

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good preparation, tho we could set it in this PR directly, or is that harder then I assume?

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (4a893e1) to head (c508500).
Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2614   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files         164      164           
  Lines       17783    17785    +2     
  Branches     1829     1830    +1     
=======================================
+ Hits        14876    14878    +2     
  Misses       2885     2885           
  Partials       22       22           
Files with missing lines Coverage Δ
...ueprints/helpers/onPremToHostedBlueprintMapper.tsx 80.32% <100.00%> (+0.32%) ⬆️
...nents/CreateImageWizard/utilities/requestMapper.ts 94.66% <100.00%> (+0.01%) ⬆️
src/store/imageBuilderApi.ts 86.88% <ø> (ø)
src/store/wizardSlice.ts 91.45% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a893e1...c508500. Read the comment docs.


🚨 Try these New Features:

@avitova
Copy link
Contributor Author

avitova commented Nov 25, 2024

@ezr-ondrej Not sure what you mean - in the first PR with on prem, we did not yet have the field, and I wanted to make sure that we actually merge on-prem into frontend, only then to have it also on backend (since it shows in API). So this is why the feature is added only now.

@ezr-ondrej
Copy link
Collaborator

I mean we should set the flag somewhere in import, right? Something should set this to true if I import on-prem blueprint :)

@@ -150,6 +150,7 @@ export const mapOnPremToHosted = (
metadata: {
parent_id: null,
exported_at: '',
is_on_prem: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that, sorry! Ignore me in that case! :)

The flag can be used later to track the usage of on prem import feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants