-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blueprints: Add flag to track on prem import usage #2614
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good preparation, tho we could set it in this PR directly, or is that harder then I assume?
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2614 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 164 164
Lines 17783 17785 +2
Branches 1829 1830 +1
=======================================
+ Hits 14876 14878 +2
Misses 2885 2885
Partials 22 22
Continue to review full report in Codecov by Sentry.
🚨 Try these New Features:
|
@ezr-ondrej Not sure what you mean - in the first PR with on prem, we did not yet have the field, and I wanted to make sure that we actually merge on-prem into frontend, only then to have it also on backend (since it shows in API). So this is why the feature is added only now. |
b32c511
to
c508500
Compare
I mean we should set the flag somewhere in import, right? Something should set this to true if I import on-prem blueprint :) |
@@ -150,6 +150,7 @@ export const mapOnPremToHosted = ( | |||
metadata: { | |||
parent_id: null, | |||
exported_at: '', | |||
is_on_prem: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, missed that, sorry! Ignore me in that case! :)
The flag can be used later to track the usage of on prem import feature.
c508500
to
5a07a7a
Compare
The flag can be used later to track the usage of on prem import feature.