-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard: Fix blueprint name update on Architecture/Distribution changes (HMS-5556) #2936
base: main
Are you sure you want to change the base?
Conversation
/jira-epic HMS-5294 |
473ed4d
to
b9dc3f6
Compare
e80f4ad
to
3055c43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2936 +/- ##
==========================================
- Coverage 85.19% 85.19% -0.01%
==========================================
Files 167 167
Lines 20904 20901 -3
Branches 2104 2103 -1
==========================================
- Hits 17810 17807 -3
Misses 3076 3076
Partials 18 18
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Thanks for working on fixing this, works really nicely! ❤️ If we populate default name on Image Output step, we can probably get rid of Could you also please add two tests? One to check the name gets updated with changes and second to check that custom blueprint name doesn't get overwritten. |
@regexowl Thank you for your comments. I didn’t remove it from the Details and Review steps because sometimes, when a user opens the Review step for the first time, the blueprint name doesn’t update. Keeping it prevents this issue from happening. Screen.Recording.2025-03-09.at.19.11.31.mov |
I see, the name is not populated until the release/arch are changed. Wouldn't that be a bug though? I mean depends on the scope of this PR, but we could both populate and update the name on the Image Output step. |
5650989
to
cbb70f7
Compare
@regexowl The name is populated when there is a value in the release/architecture, not just after it's populated. However, there is sometimes a delay, causing the blueprint not to update consistently on the first render. I explored several solutions, and I found that limiting the name generation to the Review step — and removing it from the Details step — resolves the issue with the initial render. |
I'm not sure I get it. This way if you click through to the Details step the Blueprint name is empty, but we still allow the user to proceed. Which I think is not really what we want as the empty Blueprint name input should be invalid and block the "Next" button, right? I've tried to follow through updating of the blueprint name on the Image output step. The hook seems to be triggered correctly, but what I'd guess is happening is that the |
da3105b
to
5b7c681
Compare
06d31dc
to
965fedb
Compare
need to update ':test_blueprint_import' in iqe_test |
Based on the error in IQE tests, this looks like we're overwriting a custom name with the changes. Which shouldn't be the case 🤔 |
the IQE TEST found real bug :) |
@regexowl yesterday I checked the import scenario by mistake in a different pr, and it was working good, so I thought I miss something in the IQE test :) |
6266120
to
cb476db
Compare
1b1e082
to
cd4261d
Compare
This commit resolves an issue where the blueprint name did not update when the user changed the Architecture or Distribution. Additionally, it sets an initial value for blueprintName in the WizardSlice.
This commit resolves an issue where the blueprint name did not update when the user changed the Architecture or Distribution.
Additionally, it sets an initial value for blueprintName in the WizardSlice.
FIX ISSUE: #2929
JIRA: HMS-5556