github: fix the comments in test-osbuild-composer-integration #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments were referring to the merge-base between the PR and main being used to test the base case when in fact the base is the HEAD of main at the time the PR was created or updated. This commit fixes the comments to reflect reality.
|
I had to fix the one thing that I didn't test in the fork: the |
mvo5
approved these changes
Nov 8, 2024
achilleas-k
deleted the
github/osbuild-composer-integration/fix-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments were referring to the merge-base between the PR and main being used to test the base case when in fact the base is the HEAD of main at the time the PR was created or updated.
This commit fixes the comments to reflect reality.