blueprint: rename partitioning_customizations, tweak validation, typos #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the name of the file that contains the `DiskCustomizations` from partitioning_customizations.go to disk_customizations.go to be consistent with the rest of the naming.
This commit follows the pattern of `GetRepositories()` to do validation early as part of getting the customization.
2 tasks
mvo5
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blueprint: when doing GetPartitioning() also validate
This commit follows the pattern of
GetRepositories()to dovalidation early as part of getting the customization.
blueprint: rename partitioning_customizations ->
disk_customizations
This commit changes the name of the file that contains the
DiskCustomizationsfrom partitioning_customizations.go todisk_customizations.go to be consistent with the rest of the naming.
blueprint: trivial typo fixes
[I should mention, first set of followups from https://github.com//pull/1041, there will be more]