manifest,image: add Files,Directories to bootc customizations #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 17, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
achilleas-k
reviewed
Feb 17, 2025
There was a problem hiding this comment.
This PR and commit are specifically for the bootc disk images but the commit message (summary and description) don't mention it at all. Can you make it more specific so it's clearer when reading back? The current description makes it sound like this PR introduces the customizations for the first time.
Otherwise, LGTM! Thanks :)
|
We should probably do this before selinux labelling, right? This is how the os pipeline does it IIRC. |
mvo5
force-pushed
the
bootc-files-dirs
branch
2 times, most recently
from
8313e74 to
51a9fe1
Compare
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 18, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
of course. good catch! |
mvo5
changed the title
mvo5
changed the title
mvo5
force-pushed
the
bootc-files-dirs
branch
from
51a9fe1 to
755118b
Compare
This commit adds support for Files,Directories to the bp customizations fo BootcDiskImage and RawBootcImage.
mvo5
force-pushed
the
bootc-files-dirs
branch
from
755118b to
a457b37
Compare
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 18, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
achilleas-k
requested changes
Feb 18, 2025
This commit runs selinux labeling unconfidionally. Traditionally we wanted to touch the filesystem that bootc created as little as possible. However as Achilleas rightfully pointed out we always write the /etc/fstab so we always need to label. If we go back to not write /etc/fstab and use kargs to find the rootfs (see issue#756) we probably should to revert this again and make labeling conditional again.
achilleas-k
approved these changes
Feb 20, 2025
supakeen
approved these changes
Feb 25, 2025
Uh, my bad - I should have linked the issue that promoted this directly - here it is osbuild/bootc-image-builder#834 |
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 26, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 26, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 26, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 27, 2025
This commit adds support for files/directories in blueprint customizations. This needs osbuild/images#1227 Closes: osbuild#834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for Files,Directories to the bp
customizations fo BootcDiskImage and RawBootcImage.
The integration test is in osbuild/bootc-image-builder#841 once that is green this can be considered ready. The unit test has the gap that "getInlineSources()" is not covered, I looked but did not found a good way, I would really like to get back to this at some point though (and also see if the 5 identical implementations could be somehow unified).