Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora: switch to erofs for fedora >= 43 #1239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Feb 20, 2025

See the change proposal 1. This switches our the Fedora IoT Anaconda installer, the Fedora image-installer, and our current live installer implementation over to use EroFS as per the accepted change proposal 2.


Note: this change applies to Fedora 43 since I do not want to land this change too late in the cycle in case it causes problems as it's not strictly necessary, just nice.

@supakeen
Copy link
Member Author

supakeen commented Feb 20, 2025

Needs @pcdubs's approval since as it involves Fedora IoT deliverables. If we don't want to do this because Fedora IoT is not live media (though I feel it's good to test this before we go through with it in RHEL 10) then I can back out that part :)

bcl
bcl previously approved these changes Feb 21, 2025
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The new code is repeated 3 times and could be a local function in the file.

I'm not approving since @supakeen wants @pcdubs to sign off on this first.

@supakeen
Copy link
Member Author

LGTM.

The new code is repeated 3 times and could be a local function in the file.

I'm not approving since @supakeen wants @pcdubs to sign off on this first.

Thanks, I was prefering to keep locality here ("each image type is its own self-contained function") though I'm now second guessing that.

@bcl
Copy link
Contributor

bcl commented Feb 25, 2025

Thanks, I was prefering to keep locality here ("each image type is its own self-contained function") though I'm now second guessing that.

Don't second guess yourself, it makes it easier to read :)

See the change proposal [1]. This switches our the Fedora IoT
Anaconda installer, the Fedora image-installer, and our current
live installer implementation over to use EroFS as per the
accepted change proposal [2].

Note that while the change targets Fedora 42 the commit here applies to
Fedora 43.

[1]: https://fedoraproject.org/wiki/Changes/EROFSforLiveMedia
[2]: https://pagure.io/fesco/issue/3356

Signed-off-by: Simon de Vlieger <[email protected]>
@supakeen
Copy link
Member Author

Re-targeted to Fedora 43 as beta freeze has started and it seems like a bad plan to do this between beta and final :)

@supakeen supakeen changed the title fedora: switch to erofs for fedora >= 42 fedora: switch to erofs for fedora >= 43 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants