Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedora: allow disabling weak dependencies #1252

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Feb 24, 2025

Weak dependency resolution is hardcoded per imagetype. This commit changes it so weak dependency resolution can be turned off per image.

We guard on the Fedora version to ensure we don't accidentally change older images.

This commit also disables weak dependency resolution for Fedora Minimal which I have mentioned here.

Weak dependency resolution is hardcoded per imagetype. This commit
changes it so weak dependency resolution can be turned off per image.

We guard on the Fedora version to ensure we don't accidentally change
older images.

Signed-off-by: Simon de Vlieger <[email protected]>
@supakeen supakeen requested a review from a team as a code owner February 24, 2025 20:56
@schuellerf
Copy link
Contributor

The inverted logic is necessary for "backwards compatibility" or just to map the default behavior better? I.e. disableWeakDeps=false is actually weakDeps=true

@supakeen
Copy link
Member Author

The inverted logic is necessary for "backwards compatibility" or just to map the default behavior better? I.e. disableWeakDeps=false is actually weakDeps=true

I did it because the imageType struct has no constructor and the default value for a boolean is false. It also maps pretty well on the behavior I'd like; fetch weak deps by default but explicitly disallow them per-image :)

@supakeen
Copy link
Member Author

I'll be moving this to draft so it can be rewritten to use image config(s) as per @thozza / @achilleas-k 's request.

@supakeen supakeen marked this pull request as draft February 25, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants