many: move machine id first boot to image config #1258
Conversation
Signed-off-by: Simon de Vlieger <[email protected]>
This moves the machine id handling from specific to Fedora to the image config. Signed-off-by: Simon de Vlieger <[email protected]>
| // How to handle the /etc/machine-id file | ||
| FirstBootStrategy *osbuild.MachineIdFirstBoot |
There was a problem hiding this comment.
In general, we want to avoid using osbuild stage options or types as types in ImageConfig.
I'm also not too keen on the name. FirstBootStrategy sounds way too general, while all it does is manage machine-id... 🤔
There was a problem hiding this comment.
Yes, but the status quo right now is to use them. Do I need to introduce another type and then directly convert/map that onto osbuild types?
I don't particularly like it either (everything seems to be called something-FirstBoot). It controls "ConditionFirstBoot" which is where the name comes from :)
There was a problem hiding this comment.
MachineIdFirstBoot? 🙄 I like your suggestion, but the values make it weird.
I'll let others comment since there isn't a good option.
There was a problem hiding this comment.
Yes, but the status quo right now is to use them. Do I need to introduce another type and then directly convert/map that onto osbuild types?
It is, but we want to move away from it. So, it seems natural not to use it for newly added options. So yes, ideally, you should add a new type to https://github.com/osbuild/images/tree/main/pkg/customizations if it can't be represented by a primitive type.
On the other hand, we do not need to necessarily map the stage options 1:1 to the ImageConfig option. Maybe adding just something like MachineIdUninitialized bool would be good enough? And the OS pipeline would just set the correct stage option if true.
This moves the machine id handling from specific to Fedora to the image config.
Had a chat with @achilleas-k and @thozza today who pointed out that they'd prefer this to live in the image config. Is this the right approach?