manifest: add devices/mounts to the files/dir stages in bootc #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this the files/dir stages will not have access to the created bootc container filesystem. This was found by the integration test in osbuild/bootc-image-builder#841
mvo5
requested review from
achilleas-k,
schuellerf,
supakeen and
ondrejbudai
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 26, 2025
supakeen
approved these changes
Feb 26, 2025
mvo5
added a commit
to mvo5/bootc-image-builder
that referenced
this pull request
Feb 27, 2025
achilleas-k
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the files/dir stages will not have access to the generated container filesystem.
This was found by the integration test in
osbuild/bootc-image-builder#841
P.S. this is now integration tested with osbuild/bootc-image-builder#841 that pulls this in temporarily - the bib integration test now passes locally
[edit: the integration test in bib in https://github.com/osbuild/bootc-image-builder/pull/841 has now passed with this change in CI as well]