-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootc_disk: Add support for vmdk, ova #504
Conversation
So...I tried this out along with this patch for bib
And with that, I get this:
And yes, now I realize this is harder than I thought, because we need to either:
|
OK, if the remaining work is bib side and you think this is right - then lifting draft here. |
See my in-line comment https://github.com/osbuild/images/pull/504/files#r1516881294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make pipelines run outside the build root.
Sorry for the confusion. I looked at the code before noticing the comment and it looked good but then realised the issue with the build root :) |
Similar to eb24e7e which did this for qcow2. (Also fixing the typo `buidPipeline` in the ovf copy)
We want to support generating these for bootc containers too. As the TODO says there's some clearly sharable code with `disk.go`.
OK yep updated, this generates an image! No idea if it works in vsphere yet, will ping about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Let's land it as is and we (images team) will look into the suggested refactor (which makes a ton of sense) in a followup
This is addressed now, the pipeline runs now from the bib context.
BIB PR using this: osbuild/bootc-image-builder#251
We want to support generating VMDK for bootc containers too.