Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscloud/secure-instance: fix cleaning up fleets with creation errors #4489

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

awscloud/secure-instance: fix cleaning up fleets with creation errors #4489

wants to merge 2 commits into from
+18 −6

Commits on Nov 22, 2024

  1. awscloud/secure-instance: log error code comparisons 

    We're seeing some behaviour where create fleet is not retried and
subsequently the SI cleanup fails due to the security group already
being tied to an existing instance. There is no error that an instance
was launched anyway.
    @croissanne
    croissanne committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    b48aa74 View commit details
    Browse the repository at this point in the history

  2. awscloud/secure-instance: pass on fleet information on error 

    By surfacing the output even in case of an error, the fleet ID and
instance ID can be extracted if present. Thus the instance can be
terminated before its dependencies are deleted.
    @croissanne
    croissanne committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0583dfa View commit details
    Browse the repository at this point in the history