internal/cloudapi/v2/handler: use compose id for filename #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easier tracing and finding the result in AWS, we should use the compose id in the filename.
croissanne
reviewed
Dec 17, 2024
| @@ -1233,7 +1233,7 @@ func (h *apiHandlers) postCloneComposeImpl(ctx echo.Context, id string) error { | |||
| Ami: options.Ami, | |||
| SourceRegion: options.Region, | |||
| TargetRegion: img.Region, | |||
| TargetName: fmt.Sprintf("composer-api-%s", uuid.New().String()), | |||
| TargetName: fmt.Sprintf("composer-api-%s", finalJob), | |||
There was a problem hiding this comment.
This only change the clones (so when copying the image over to different regions).
In general I'm not at all opposed to it but you'll probably need to pick the osbuild job because in koji jobs the final job is the koji-finalize job, which depends on up to 4 osbuild jobs, and they can't all have the same name.
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier tracing and finding the result in AWS,
can we use the compose id in the filename?
Is this a valid suggestion?
If this might not be unique enough, we could also append some random string?