-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: osbuild-composer is not able to build RHEL-8 images since RHEL-9.5 (RHEL-71397) #4651
Draft
thozza
wants to merge
9
commits into
osbuild:main
Choose a base branch
from
thozza:RHEL-71397
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomáš Hozza <[email protected]>
Move testing on the latest RHEL-9 GA testing to the latest GA minor version, which is 9.5. Signed-off-by: Tomáš Hozza <[email protected]>
Completely remove the /etc/osbuild-composer/repositories directory used for repo overrides, to ensure that only repos from the RPM are used. Moreover, instead of trying to restart osbuild-composer, which is always a tricky thing to do, let's just stop all services and call the Weldr API. Since the service is socket-activated, this will start all the necessary services. Signed-off-by: Tomáš Hozza <[email protected]>
This test case is no longer being run with an osbuild-composer version lower than v97, so there's no need to special case it. Signed-off-by: Tomáš Hozza <[email protected]>
This will allow using them inside Bash function that return values, without tainting the returned value. Signed-off-by: Tomáš Hozza <[email protected]>
c8s is EOL. Signed-off-by: Tomáš Hozza <[email protected]>
Test actual image builds of older distros on RHEL and CentOS, to catch issues such as https://issues.redhat.com/browse/RHEL-71397. The test can be later extended to cover also Fedora, but this is out of scope at this point, since the goal is to ensure that RHEL cross-distro builds work, because these differ a lot. Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
achilleas-k
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some really nice cleanups here, on top of the main test. TY! LGTM (WIP).
Signed-off-by: Tomáš Hozza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP