Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: osbuild-composer is not able to build RHEL-8 images since RHEL-9.5 (RHEL-71397) #4651

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

thozza
Copy link
Member

@thozza thozza commented Mar 18, 2025

WIP

thozza added 8 commits March 18, 2025 14:38
Signed-off-by: Tomáš Hozza <[email protected]>
Move testing on the latest RHEL-9 GA testing to the latest GA minor
version, which is 9.5.

Signed-off-by: Tomáš Hozza <[email protected]>
Completely remove the /etc/osbuild-composer/repositories directory used
for repo overrides, to ensure that only repos from the RPM are used.

Moreover, instead of trying to restart osbuild-composer, which is always
a tricky thing to do, let's just stop all services and call the Weldr
API. Since the service is socket-activated, this will start all the
necessary services.

Signed-off-by: Tomáš Hozza <[email protected]>
This test case is no longer being run with an osbuild-composer version
lower than v97, so there's no need to special case it.

Signed-off-by: Tomáš Hozza <[email protected]>
This will allow using them inside Bash function that return values,
without tainting the returned value.

Signed-off-by: Tomáš Hozza <[email protected]>
Test actual image builds of older distros on RHEL and CentOS, to catch
issues such as https://issues.redhat.com/browse/RHEL-71397.

The test can be later extended to cover also Fedora, but this is out of
scope at this point, since the goal is to ensure that RHEL cross-distro
builds work, because these differ a lot.

Signed-off-by: Tomáš Hozza <[email protected]>
Signed-off-by: Tomáš Hozza <[email protected]>
@thozza thozza added the WIP+test Work in progress but run Gitlab CI. label Mar 18, 2025
@thozza thozza requested a review from a team as a code owner March 18, 2025 13:39
@thozza thozza requested review from mvo5, achilleas-k and supakeen and removed request for a team March 18, 2025 13:39
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some really nice cleanups here, on top of the main test. TY! LGTM (WIP).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP+test Work in progress but run Gitlab CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants