Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump github.com/getkin/kin-openapi to v0.131.0 #4655

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

croissanne
Copy link
Member

As deepmap/oapi-codegen didn't work with this newer version, upgrade to oapi-codegen/oapi-codegen v2.

Mitigating CVE-2025-30153

@croissanne croissanne requested review from thozza and a team as code owners March 21, 2025 13:37
@croissanne croissanne requested review from mvo5, supakeen, ondrejbudai and a team and removed request for a team March 21, 2025 13:37
achilleas-k
achilleas-k previously approved these changes Mar 21, 2025
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Types and structs look cleaner.

ondrejbudai
ondrejbudai previously approved these changes Mar 24, 2025
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is awesome! ❤️

As deepmap/oapi-codegen didn't work with this newer version, upgrade to
oapi-codegen/oapi-codegen v2.

Mitigating CVE-2025-30153
Fixed distribution list type, function signatures (later versions parse
uuids in the generated code), defaults actually being set and added
x-go-type where needed.
@croissanne croissanne force-pushed the kin-openapi-131 branch 2 times, most recently from 6088bc7 to 0a46d52 Compare March 25, 2025 09:36
Removes an ineffectual GO111MODULE=off assignment in the build phase, as
we require go to run in module mode at that stage.

In the check phase we run without go modules, so the same stipulation as
on RHEL applies, where the vendor directory gets ignored in certain
cases. Also remove `-mod=vendor` from GOFLAGS on RHEL during the check
phase, as without go modules this is an ineffectual flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants