Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: import otk #129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

project: import otk #129

wants to merge 1 commit into from

Conversation

supakeen
Copy link
Member

Import the documentation for otk.

Import the documentation for `otk`.

Signed-off-by: Simon de Vlieger <[email protected]>
@ochosi
Copy link
Contributor

ochosi commented Nov 14, 2024

I guess this isn't ready yet, the import scripts still need to be updated, right?

@supakeen
Copy link
Member Author

I guess this isn't ready yet, the import scripts still need to be updated, right?

What do you mean? There's no need to import the README as the project has a direct index.md. And there's no need to import other things a-la osbuild modules either? :)

@ochosi
Copy link
Contributor

ochosi commented Nov 15, 2024

But how will it get updated? (Sorry, maybe I'm missing something obvious)

@supakeen
Copy link
Member Author

But how will it get updated? (Sorry, maybe I'm missing something obvious)

It won't. The documentation will be removed from the otk repository and included here instead much like the documentation for other projects in this repository.

If you want I can adjust this PR to instead use the pipelines to auto pull in the doc/ subdirectory of the otk repository but that's different from how the other pages work here.

We only pull in the README's of a few selected projects and then we autogenerate the content of modules/ under osbuild here.

@ochosi
Copy link
Contributor

ochosi commented Nov 19, 2024

But how will it get updated? (Sorry, maybe I'm missing something obvious)

It won't. The documentation will be removed from the otk repository and included here instead much like the documentation for other projects in this repository.

If you want I can adjust this PR to instead use the pipelines to auto pull in the doc/ subdirectory of the otk repository but that's different from how the other pages work here.

We only pull in the README's of a few selected projects and then we autogenerate the content of modules/ under osbuild here.
I don't really agree - we do pull multiple pages per project. That is most of the 'developer guide' pages that this PR also targets.

The goal of the importer was to keep as many of the docs as possible with the code. This should help with getting the docs updated (e.g. how to install) when the project changes.

Is there a reason for otk to deviate from this or am I missing something?

@ochosi ochosi self-assigned this Nov 19, 2024
@supakeen
Copy link
Member Author

supakeen commented Nov 20, 2024

But how will it get updated? (Sorry, maybe I'm missing something obvious)

It won't. The documentation will be removed from the otk repository and included here instead much like the documentation for other projects in this repository.
If you want I can adjust this PR to instead use the pipelines to auto pull in the doc/ subdirectory of the otk repository but that's different from how the other pages work here.
We only pull in the README's of a few selected projects and then we autogenerate the content of modules/ under osbuild here.
I don't really agree - we do pull multiple pages per project. That is most of the 'developer guide' pages that this PR also targets.

The goal of the importer was to keep as many of the docs as possible with the code. This should help with getting the docs updated (e.g. how to install) when the project changes.

Is there a reason for otk to deviate from this or am I missing something?

There is no deviation here right?

This is following the status quo of how the documentation for osbuild, etc work. Their documents live in this repository; and we only import their READMEs and in the osbuild special case we also pull the module documentation but for example the rest of its docs live in this repository.

Same goes for the "on premises" and "hosted" content though I guess those live across tools.

I'd be happy to expand the github action to instead pull the docs subdirectory directly from otk and place it here if that's how we want to do this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants