Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't skip main component when creating SSP with author jinja #1834

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: don't skip main component when creating SSP with author jinja #1834

wants to merge 1 commit into from
+0 −2

Conversation

rahearn
Copy link
Contributor

@rahearn rahearn commented Mar 11, 2025

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@rahearn rahearn requested a review from a team as a code owner March 11, 2025 17:09
@rahearn rahearn changed the title Don't skip main component in ssp_io.get_control_response fix: Don't skip main component in ssp_io.get_control_response Mar 11, 2025
@rahearn rahearn changed the title fix: Don't skip main component in ssp_io.get_control_response fix: don't skip main component when creating SSP with author jinja Mar 11, 2025
@rahearn rahearn mentioned this pull request Mar 11, 2025
Merged
rahearn
rahearn commented Mar 11, 2025
View reviewed changes
trestle/core/ssp_io.py
@@ -302,8 +302,6 @@ def get_control_response(
header = f'Implementation for part {label}'
md_writer.new_header(1, title=header)
for comp_name, comp_response in response_per_component.items():
if comp_name == SSP_MAIN_COMP_NAME:
continue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between this and the pre - #1358 behavior is that Component: This System will be output for each part now, where it was skipped earlier.

@jpower432 jpower432 added this to the v3.8.1 milestone Mar 12, 2025
jpower432
jpower432 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpower432 jpower432 jpower432 approved these changes

@AleJo2995 AleJo2995 Awaiting requested review from AleJo2995

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.8.1
Development

Successfully merging this pull request may close these issues.

get_control_response missing "This System" component
2 participants
@rahearn @jpower432