-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap tests/doctests into with_unicode(false)
#3271
Conversation
I think calling it in each |
I didn't realize that |
Regarding @benlorenz's comment, I've opened Nemocas/AbstractAlgebra.jl#1588 |
8050888
to
141794b
Compare
Now that Nemocas/AbstractAlgebra.jl#1586 is available, there are no longer any race conditions between different workers as |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3271 +/- ##
==========================================
- Coverage 81.81% 81.80% -0.02%
==========================================
Files 556 556
Lines 74134 74150 +16
==========================================
+ Hits 60653 60656 +3
- Misses 13481 13494 +13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, seems to work fine.
I did some local tests with several Oscar instances using the same directory, running with many workers and tests + doctests in parallel.
* Wrap tests/doctests into `with_unicode(false)` * Adapt all `allow_unicode` in test files
Needs Nemocas/AbstractAlgebra.jl#1586.
If one has unicode enabled and runs tests/doctests/
doctest_fix
locally, this may lead to inconsistent results (as the printing may use unicode).This PR wraps all of these functions into a block that disables unicode temporarily to get consistent output.