Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Fix constructor for 1511.03209 model #4015

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

HereAround
Copy link
Member

A small fix needed.

cc @emikelsons

@HereAround HereAround added bug Something isn't working topic: FTheoryTools labels Aug 15, 2024
@HereAround HereAround requested a review from emikelsons August 15, 2024 13:23
@HereAround HereAround enabled auto-merge (rebase) August 15, 2024 13:23
@HereAround HereAround disabled auto-merge August 15, 2024 13:38
@HereAround HereAround enabled auto-merge (squash) August 15, 2024 13:38
@HereAround HereAround requested a review from apturner August 15, 2024 15:53
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (5c69c6c) to head (f1f4207).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4015   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         596      596           
  Lines       82055    82054    -1     
=======================================
  Hits        69381    69381           
+ Misses      12674    12673    -1     
Files Coverage Δ
.../FTheoryTools/src/LiteratureModels/constructors.jl 93.77% <ø> (+0.30%) ⬆️

Copy link
Collaborator

@emikelsons emikelsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the tests pass

@HereAround HereAround merged commit 7a8eb6c into oscar-system:master Aug 15, 2024
26 of 28 checks passed
@HereAround HereAround deleted the Fix branch August 15, 2024 16:53
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants