Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialization fixes #4021

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Serialization fixes #4021

merged 3 commits into from
Aug 19, 2024

Conversation

lgoettgens
Copy link
Member

I extracted everything not related to Lie algebras from #3980 to here to clear the way for a merge of the fixes.

This will probably have some conflicts w.r.t. #4020, but I am happy to help you with that.

@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Aug 19, 2024
This was referenced Aug 19, 2024
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.55%. Comparing base (550af10) to head (da32ae6).
Report is 2 commits behind head on master.

Files Patch % Lines
src/Serialization/containers.jl 11.76% 15 Missing ⚠️
src/Serialization/main.jl 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
+ Coverage   84.08%   84.55%   +0.47%     
==========================================
  Files         597      597              
  Lines       82103    82180      +77     
==========================================
+ Hits        69034    69490     +456     
+ Misses      13069    12690     -379
Files Coverage Δ
src/Serialization/serializers.jl 99.09% <100.00%> (+0.01%) ⬆️
src/Serialization/main.jl 85.94% <90.00%> (ø)
src/Serialization/containers.jl 83.59% <11.76%> (-4.16%) ⬇️

... and 40 files with indirect coverage changes

antonydellavecchia
antonydellavecchia approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@antonydellavecchia antonydellavecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I should be able to deal with conflicts

@antonydellavecchia antonydellavecchia enabled auto-merge (rebase) August 19, 2024 11:00
@antonydellavecchia antonydellavecchia enabled auto-merge (squash) August 19, 2024 11:03
@antonydellavecchia antonydellavecchia merged commit a7f7564 into master Aug 19, 2024
29 checks passed
@antonydellavecchia antonydellavecchia deleted the lg/adv/serialization-fixes branch August 19, 2024 11:03
HechtiDerLachs pushed a commit to HechtiDerLachs/Oscar.jl that referenced this pull request Sep 13, 2024
@lgoettgens @antonydellavecchia @HechtiDerLachs
Serialization fixes (oscar-system#4021)
feec942 
* Add SRow serialization

Co-authored-by: Antony Della Vecchia <[email protected]>

* Random serialization fixes

* Add `Oscar.@add_all_serialization_functions`

---------

Co-authored-by: Antony Della Vecchia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonydellavecchia antonydellavecchia antonydellavecchia approved these changes

Assignees
No one assigned
Labels
experimental Only changes experimental parts of the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgoettgens @antonydellavecchia