LieAlgebras: Collect all types to a single file #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieTheory
experimental
lgoettgens
changed the title
lgoettgens
force-pushed
the
lg/collect-structs
branch
from
9fd8a87 to
0f44ec6
Compare
- formatting - add some parent type - remove CoxeterGroup type as wished by felix-roehrich
felix-roehrich
approved these changes
Aug 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
+ Coverage 84.15% 84.64% +0.48%
==========================================
Files 598 599 +1
Lines 82386 82444 +58
==========================================
+ Hits 69330 69782 +452
+ Misses 13056 12662 -394
|
felix-roehrich
approved these changes
Aug 23, 2024
|
@joschmitt woulx you wanna do the favor here as well? |
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 13, 2024
* Collect all types to a single file * Move an outer constructor to inner * Small refactorings - formatting - add some parent type - remove CoxeterGroup type as wished by felix-roehrich * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I collected all
abstract types andstructs to a single file, as this is already done in other parts of Oscar.Furthermore some minor changes I noticed when seeing all of the struct definitions right next to each other.