Intersection theory: fix issue #4512 and more #4526
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4526 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 672 672
Lines 89126 89143 +17
=======================================
+ Hits 75225 75242 +17
Misses 13901 13901
|
lgoettgens
changed the title
| Products and blowups are described elsewhere. | ||
| Products and blow_ups are described elsewhere. |
There was a problem hiding this comment.
Thanks for renaming the method blowup(...) to blow_up(...).
It seems that in some places such as here, the word blowup was changed as well, where it is not a function name but a just mathematical terminology. Maybe these changes were unintended?
There was a problem hiding this comment.
@simonbrandhorst thanks; reversed with 1d22cc0
| fix_points(X::TnVariety) | ||
|
|
||
| Return the fix points representing `X`. |
There was a problem hiding this comment.
Please double check the spelling of "fix points" I believe it is 'fixed points'.
| @@ -5,6 +5,10 @@ DocTestSetup = Oscar.doctestsetup() | |||
|
|
|||
| # Abstract Variety Maps | |||
|
|
|||
| ## Types | |||
|
|
|||
| The OSCAR type for abstract varieties is `AbstractVarietyMap`. | |||
There was a problem hiding this comment.
Maybe this?
| The OSCAR type for abstract varieties is `AbstractVarietyMap`. | |
| The OSCAR type for abstract variety maps is `AbstractVarietyMap`. |
| @@ -3,12 +3,12 @@ CurrentModule = Oscar | |||
| DocTestSetup = Oscar.doctestsetup() | |||
| ``` | |||
|
|
|||
| # Blowups | |||
| # Blow_Ups | |||
There was a problem hiding this comment.
| # Blow_Ups | |
| # Blow Ups |
| @@ -177,6 +177,8 @@ Given an element `x` of the Chow ring of an abstract variety `X`, say, return th | |||
|
|
|||
| ###### Examples | |||
|
|
|||
| Lines on a General Cubic Hypersurface in $\mathbb P^3$ | |||
There was a problem hiding this comment.
Shouldn't the capitalization here and elsewhere be like this?
| Lines on a General Cubic Hypersurface in $\mathbb P^3$ | |
| Lines on a general cubic hypersurface in $\mathbb P^3$ |
Or maybe this is meant to be like a headline -- but then I'd also expect it to be boldface, or maybe an actual sub^N-section:
| Lines on a General Cubic Hypersurface in $\mathbb P^3$ | |
| ##### Lines on a General Cubic Hypersurface in $\mathbb P^3$ |
|
|
||
| Return an abstract_variety with a torus action, represented by the fixed points. | ||
| """ | ||
| tn_variety(n::Int, points::Vector{Pair{P, Int}}) where P = TnVariety(n::Int, points::Vector{Pair{P, Int}}) where P |
There was a problem hiding this comment.
| tn_variety(n::Int, points::Vector{Pair{P, Int}}) where P = TnVariety(n::Int, points::Vector{Pair{P, Int}}) where P | |
| tn_variety(n::Int, points::Vector{Pair{P, Int}}) where P = TnVariety(n::Int, points::Vector{Pair{P, Int}}) |
Intersection theory:
ping @pbelmans, @thofma