Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip docs preview for dependabot PRs #4554

Merged

Conversation

lgoettgens
Copy link
Member

Unlike workflows triggered by other actors, this means [workflows triggered by dependabot] receive a read-only GITHUB_TOKEN and do not have access to any secrets that are normally available. This will cause any workflows that attempt to write to the repository to fail when they are triggered by Dependabot.
(https://docs.github.com/en/code-security/dependabot/troubleshooting-dependabot/troubleshooting-dependabot-on-github-actions#troubleshooting-failures-when-dependabot-triggers-existing-workflows)

This means that pushing the documentation preview will fail for dependabot PRs (see e.g. https://github.com/oscar-system/Oscar.jl/actions/runs/13183920804/job/36809531604?pr=4550#step:6:622). Thus, we should skip the preview in these cases.

@lgoettgens lgoettgens added documentation Improvements or additions to documentation CI labels Feb 6, 2025
@lgoettgens lgoettgens added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes and removed documentation Improvements or additions to documentation labels Feb 6, 2025
@lgoettgens lgoettgens requested a review from benlorenz February 6, 2025 20:07
@thofma
Copy link
Collaborator

thofma commented Feb 6, 2025

does every repo need this?

@lgoettgens
Copy link
Member Author

does every repo need this?

Only the ones that have doc previews enabled.
Let's first try if it indeed works here, before spending more energy on the other repos.

@fingolfin fingolfin enabled auto-merge (squash) February 6, 2025 23:03
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, it works

@fingolfin fingolfin merged commit a06a5ba into oscar-system:master Feb 7, 2025
26 of 32 checks passed
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (069bd41) to head (0571c38).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4554      +/-   ##
==========================================
+ Coverage   84.41%   84.43%   +0.02%     
==========================================
  Files         672      673       +1     
  Lines       89155    89624     +469     
==========================================
+ Hits        75256    75673     +417     
- Misses      13899    13951      +52     

see 11 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants