[FTheoryTools] More improvements

[HereAround]

• Avoid "base =" in doctests (code snippet will not execute in repl)
• Fix the extra-long tests (undefined variable h2)

cc @apturner @emikelsons

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (ca6338c) to head (71b3b06).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4555      +/-   ##
==========================================
- Coverage   84.43%   84.42%   -0.02%     
==========================================
  Files         673      673              
  Lines       89624    89624              
==========================================
- Hits        75676    75662      -14     
- Misses      13948    13962      +14     

Files with missing lines	Coverage Δ
...mental/FTheoryTools/src/TateModels/constructors.jl	97.46% <ø> (ø)
...FTheoryTools/src/WeierstrassModels/constructors.jl	95.65% <ø> (ø)

... and 4 files with indirect coverage changes

[emikelsons]

I see that "base =" also appears in /test/weierstrass_models.jl and /test/tate_models.jl, are these instances a potential issue?

[HereAround]

@benlorenz I have just pushed a change here which should fix the extra-long tests. Please take a look if this PR is ready for merge.

The changes are rather trivial/do not involve an F-theory "magic":

• First commit: Changed variable name in the doc tests/examples, so that every code snippet (on F-theory) does successfully execute when a user copies it to the REPL. (Currently, two doctests/examples include the assignment base = which errors at least in my Julia REPL).
• Second commit: Said fix for the extra long tests.

(Alternatively, I can of course make a PR just with the 2nd commit only.)

[HereAround]

I see that "base =" also appears in /test/weierstrass_models.jl and /test/tate_models.jl, are these instances a potential issue?

While we are at it, probably best to fix them too. I will add this to the next PR though, so that the extra long tests are fixed quickly.

[emikelsons]

Looks good and the tests pass