Rework binary integer description error-handling #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reworks binary integer description error-handling using the
Optional<Fallible<T>>
approach (#95). In other words: invalid inputs return nil, and out-of-bounds inputs return the truncated results and an error indicator—like basically every otherBinaryInteger
operation. Note that onlyTextInt
exposes the new functionality and that the methods onBinaryInteger
replaceerror
withnil
. Additionally, this patch removesTextInt.Error
(#125) and allStaticString
conveniences (awaiting a unified abstraction). It is also a bit faster.