Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mindate, maxdate args in query function #3

Merged
merged 1 commit into from
Feb 1, 2024
Merged

feat: add mindate, maxdate args in query function #3

merged 1 commit into from
Feb 1, 2024

Conversation

EverVino
Copy link

@EverVino EverVino commented Feb 1, 2024 •
edited
Loading

Pull Request description

  • Add mindate, maxdate as args in query function
  • Add typing type to code

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Reviewer's checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved .

@EverVino EverVino requested a review from xmnlab February 1, 2024 00:52
@xmnlab xmnlab changed the title refactor: add mindate, maxdate args in query function feat: add mindate, maxdate args in query function Feb 1, 2024
@xmnlab xmnlab merged commit d0fce78 into main Feb 1, 2024
7 of 8 checks passed
@xmnlab xmnlab deleted the update-pymed branch February 1, 2024 01:03
@xmnlab
Copy link
Member

xmnlab commented Feb 1, 2024

thanks @EverVino

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab Awaiting requested review from xmnlab

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EverVino @xmnlab