-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update scraping code #6
Conversation
The failing test will need more investigation |
@xmnlab the test is not passing. Maybe its about the version. What do you think? |
hey @EverVino I am taking a look into that now |
not really sure about this error, but this is the context: you changed from
to
the error happens here: https://github.com/osl-incubator/pymedx/blob/main/src/pymedx/article.py#L165 the error states: so my guess is that the new |
let me know if you want to debug directly inside the CI and I can enable that for you |
@xmnlab ready for a review |
Basically the problem was that Element is a generator of classes _Element |
🎉 This PR is included in version 0.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
PMID, doi field were extracting more data than expected fix this part with getContentUnique function,
abstract and title field was not extracting the full content fix this part with getAllContent function
For some test that I ran locally I notice that some articles or items does not have abstract maybe due its old date.
How to test these changes
Run a simple query
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Reviewer's Checklist
main
branch