Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Check if project-name is null #106

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Conversation

joel5vega
Copy link
Contributor

Pull Request description

Issue #28

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@joel5vega
Copy link
Contributor Author

@xmnlab , I've added one conditional to check if project-name is null, please check if it is implemented correctly

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the top of my head, I would say that it should be something simpler, something like

default_project_name = self.defaults.get('project-name', '') or ''

@joel5vega
Copy link
Contributor Author

Sure @xmnlab , I will correct and update it!

@xmnlab
Copy link
Member

xmnlab commented Jan 3, 2024

The CI is still failing about distlib issue.
I will work on that later.
But for now this PR looks good to me. Thanks

@xmnlab xmnlab merged commit 82a93df into osl-incubator:main Jan 3, 2024
2 of 8 checks passed
Copy link

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants