Issue#46 #48
Merged
Issue#46 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e can load wihtout topics - only card fails
…e through query passed to card as props
jonathanhaviv
approved these changes
Sep 15, 2022
| @@ -31,6 +31,8 @@ const MetricsCard = ({ | |||
| if (query) { | |||
| const { loading, data } = useQuery(query, { ...variables }); | |||
| value = loading ? "Loading..." : keySearch(data, searchingFor); | |||
| console.log("value", value); | |||
There was a problem hiding this comment.
Small suggestion, just to remove this console.log
remove console.log statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46
What?
Addresses rendering of Topic page when connecting to a new cluster that does not have any topics.
Why?
New users will think the tool is not working when they connect to a new Kafka cluster.
How?
The underminISR metric card now accepts a query, rather than accepting the value passed as props. The MetricCard component has been refactored to display a generic message when a metric is unavailable (undefined). Additionally, the RealTimeLineChart does not create plotted data points if the time series data value is undefined.