Add reusable period shortcut component #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
petterhj
commented
Sep 6, 2023
petterhj
commented
simenheg
approved these changes
Sep 14, 2023
Comment on lines
171
to
179
| isSuggestedPeriod() { | ||
| if ( | ||
| this.periodRange && | ||
| this.newestObjective?.startDate && | ||
| this.newestObjective?.endDate && | ||
| isEqual(this.periodRange[0], this.newestObjective.startDate.toDate()) && | ||
| isEqual(this.periodRange[1], this.newestObjective.endDate.toDate()) | ||
| ) { | ||
| return true; | ||
| } | ||
| return false; | ||
| }, |
There was a problem hiding this comment.
A.K.A.
return (
this.periodRange &&
this.newestObjective?.startDate &&
this.newestObjective?.endDate &&
isEqual(this.periodRange[0], this.newestObjective.startDate.toDate()) &&
isEqual(this.periodRange[1], this.newestObjective.endDate.toDate())
);? ;)
| @onClick="$emit('click', $event)" | ||
| > | ||
| <span class="pkt-txt-14">{{ label }}</span> | ||
| <span v-if="formattedPeriod" class="pkt-txt-12-light"> |
There was a problem hiding this comment.
Dette er smått ass, på grensen til uleselig for meg, men kanskje bare jeg som har gammelmannsøyne. 😜
Comment on lines
+30
to
+39
| startDate: { | ||
| type: [Date, Boolean], | ||
| required: false, | ||
| default: null, | ||
| }, | ||
| endDate: { | ||
| type: [Date, Boolean], | ||
| required: false, | ||
| default: null, | ||
| }, |
There was a problem hiding this comment.
Vi har det i alle fall i src/config/periods.js (all)
Comment on lines
69
to
71
| span { | ||
| display: block; | ||
| } |
There was a problem hiding this comment.
Like gjerne bruke <div> for dem da, siden de ikke skal være inline?
petterhj
force-pushed
the
period-select-shortcut
branch
from
654fcb5 to
e7b630a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.