Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disregard whitespace in whitelist check #889

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

simenheg
Copy link
Collaborator

Disregard leading and trailing whitespace in both input email and whitelisted domains to make the check more robust against unintentionally added whitespace.

@simenheg simenheg requested a review from a team October 11, 2023 11:32
Disregard leading and trailing whitespace in both input email and
whitelisted domains to make the check more robust against
unintentionally added whitespace.
@simenheg simenheg force-pushed the domain-whitelist-trim branch from 710bf7d to 3b4931a Compare October 12, 2023 13:13
Copy link
Collaborator

@petterhj petterhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simenheg simenheg merged commit 6628837 into main Oct 12, 2023
@simenheg simenheg deleted the domain-whitelist-trim branch October 12, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants