Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display name computation in team member list #912

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

simenheg
Copy link
Collaborator

@simenheg simenheg commented Nov 7, 2023

When adding a new member to a team, the team member list is rendered several times before settling. The user attributes are missing on the first render, so take that into account in the display name computation.

When adding a new member to a team, the team member list is rendered
several times before settling. The user attributes are missing on the
first render, so take that into account in the display name
computation.
@simenheg simenheg requested a review from a team November 7, 2023 08:51
Copy link
Collaborator

@petterhj petterhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@simenheg simenheg merged commit 6d7959e into main Nov 7, 2023
3 checks passed
@simenheg simenheg deleted the fix-team-member-display-name branch November 7, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants