Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disused progression chart component #924

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Remove disused progression chart component #924

merged 1 commit into from
Nov 13, 2023

Conversation

simenheg
Copy link
Collaborator

No description provided.

@simenheg simenheg requested a review from a team November 13, 2023 10:52
petterhj
petterhj approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@petterhj petterhj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ligger igjen referanser til d3-ease/d3-interpolate i jest.config.js.

@simenheg
Copy link
Collaborator Author

Ligger igjen referanser til d3-ease/d3-interpolate i jest.config.js.

Ja, d3-interpolate trengs i hvertfall der fortsatt fordi den dras inn som en avhengighet av en annen D3-komponent. Tenkte at den andre også kunne bli liggende der i tilfelle den blir dratt inn som en avhengighet av en annen komponent senere, siden feilmeldinga fra Jest er litt kryptisk å debugge. 😅

@simenheg simenheg merged commit 7fcc3b6 into main Nov 13, 2023
@simenheg simenheg deleted the remove-progression-chart branch November 13, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petterhj petterhj petterhj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simenheg @petterhj