Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace D3.js with a more high level charting library #955

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Conversation

petterhj
Copy link
Collaborator

chart

@petterhj petterhj requested a review from a team January 10, 2024 13:22
Copy link
Collaborator

@simenheg simenheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM! 🙌

Tippy.js kan vel også fjernes nå?

Comment on lines +163 to +166
this.kpi.name
.replace(/\s+/g, '-')
.replace(/[/\\?%*!:|"<>]/g, '')
.toLowerCase(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funker det å gjenbruke slugify-funksjonen vår til dette?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jo, i utgangspunktet. Usikker på om vi må restrukturere litt med tanke på delte pakker (./common) mellom frontend og functions 🤔

@petterhj petterhj merged commit ef826b9 into main Jan 15, 2024
3 checks passed
@petterhj petterhj deleted the chart-lib branch January 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants